[WIP] Streamable HTTPCallable functions (Alt. to #14290) #14376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial support for Streamable functions.
Change call to AsyncThrowingStream<HTTPSCallableResult, Error>
Remove old test function.
Remove old test
Add a full working test for stremableFunction. Refactor.
Add Json capabilities to parse an HTTP result back and forth. Updating Unit tests.
Cleanup
Add doc for processResponseDataForStreamableContent.
Update func to have a callback. Update UnitTests
Remove test.
Fetch Main branch.
…/firebase-ios-sdk into iOS-Stremable-Functions
Updated to renamed code. From callableResultFromResponse to callableResult
Run style.sh
Fix concurrency " mutation of captured var 'response' in concurrently-executing code" and typos.
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
This file is not needed.
This file is not needed.
Add throws Remove DO - CATCH
…/firebase-ios-sdk into iOS-Stremable-Functions
Accept suggestion. Thanks. Co-authored-by: Nick Cooke <[email protected]>
Remove optionals.
…/firebase-ios-sdk into iOS-Stremable-Functions
Revert func to non DISPACTCH. Will work on a fix with @ncooke3
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Generated by 🚫 Danger |
Apple API Diff ReportCommit: ab2be0b FirebaseFunctionsStructuresCallable[ADDED] stream(_:)Swift:
+ public func stream ( _ data : Request ) async throws -> AsyncThrowingStream < Response , Error > |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.